fix(ui): display loader during async loading component #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I rencently introduced Async Components but some of them are really big, and the loading time is noticable. It renders as blank area which is not good. So I used `loadingComponent` property to fill the space during the loading, and improved a bit the loading strategy to improve the UX.
madeindjs
commented
Nov 20, 2024
| import BuilderSettingsProperties from "./BuilderSettingsProperties.vue"; | ||
| import BuilderSettingsBinding from "./BuilderSettingsBinding.vue"; | ||
| import BuilderSettingsVisibility from "./BuilderSettingsVisibility.vue"; | ||
| import BuilderCopyText from "./BuilderCopyText.vue"; | ||
| import BuilderAsyncLoader from "./BuilderAsyncLoader.vue"; | ||
|
|
||
| const BuilderSettingsHandlers = defineAsyncComponent({ |
There was a problem hiding this comment.
The BuilderSettingsHandlers contains the monaco editor, so we don't want to wait everything to be loaded to display the settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently introduced Async Components, but some of them are massive, and the loading time is noticeable. It renders as blank area, which is not good.
So I used
loadingComponentproperty to fill the space during the loading, and improved a bit the loading strategy to improve the UX.Screencast.From.2024-11-20.21-38-31.mp4