Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): use BuilderSelect for handlers + implement Design System - WF-45 #638

Merged
merged 1 commit into from
Nov 28, 2024
Merged

feat(ui): use BuilderSelect for handlers + implement Design System - WF-45 #638

merged 1 commit into from
Nov 28, 2024

Conversation

madeindjs
Copy link
Collaborator

@madeindjs madeindjs commented Nov 18, 2024 •
edited
Loading

Right now, an event handler has to be selected using a standard select. This works well for small apps, but it’s a bad experience for bigger apps.

Screencast.From.2024-11-25.22-55-26.mp4

So I reused the BuilderSelect and improved a bit to support search. I also integrated the Writer's design for the dropdown (Figma)

Screencast.From.2024-11-25.22-51-53.mp4

Technically

  1. implement WdsDropdownMenu component that use the design from the design system
  2. rework a lot the BuilderSelect component
    • used the library floating-ui which is a more robust solution to place dropdown (with fallback placement)
    • use the WdsDroprownMenu
    • use defineModel to avoid double state bug
    • improve accessibility (some div wasn't clickable with the tab nav)
  3. use the BuilderSelect in BuilderSettingsHandlers

@madeindjs madeindjs self-assigned this Nov 18, 2024
@madeindjs madeindjs changed the title feat(ui): use BuilderSelect for hanlders - WF-45 feat(ui): use BuilderSelect for handlers + implement Dropdown Design System - WF-45 Nov 25, 2024
@madeindjs madeindjs changed the title feat(ui): use BuilderSelect for handlers + implement Dropdown Design System - WF-45 feat(ui): use BuilderSelect for handlers + implement Design System - WF-45 Nov 25, 2024
@madeindjs madeindjs marked this pull request as ready for review November 25, 2024 22:37
@ramedina86 ramedina86 merged commit 0f8a653 into writer:dev Nov 28, 2024
15 of 16 checks passed
ramedina86 added a commit that referenced this pull request Nov 29, 2024
@ramedina86
Squashed commit of the following:
b910e85 
commit 0f8a653
Merge: c6bd286 5ea2448
Author: Ramiro Medina <[email protected]>
Date:   Thu Nov 28 17:54:43 2024 +0100

    Merge pull request #638 from madeindjs/WF-45

    feat(ui): use `BuilderSelect` for handlers + implement Design System - WF-45

commit c6bd286
Merge: c789209 4998ace
Author: Ramiro Medina <[email protected]>
Date:   Thu Nov 28 10:03:36 2024 +0100

    Merge pull request #654 from mmikita95/fix-pytest-warnings

    fix: register `set_token` mark to avoid pytest warnings

commit c789209
Merge: 8774f9b 93a4f6e
Author: Ramiro Medina <[email protected]>
Date:   Thu Nov 28 10:01:53 2024 +0100

    Merge pull request #622 from mmikita95/chore-serialize-non-empty-content

    chore: serialize tool calls messages with non-empty content

commit 8774f9b
Merge: ec53f21 a8f42de
Author: Ramiro Medina <[email protected]>
Date:   Wed Nov 27 09:30:02 2024 +0100

    Merge pull request #646 from writer/WF-123-fix-examples-versions

    fix(WF-123): template apps have incorrect version after generation

commit 4998ace
Author: mmikita95 <[email protected]>
Date:   Wed Nov 27 10:20:04 2024 +0300

    fix: register `set_token` mark to avoid pytest warnings

commit 5ea2448
Author: Alexandre Rousseau <[email protected]>
Date:   Mon Nov 18 21:33:27 2024 +0100

    feat(ui): use `BuilderSelect` for handlers + implement Design System - WF-45

commit a8f42de
Author: Mateusz Russak <[email protected]>
Date:   Fri Nov 22 23:24:36 2024 +0100

    fix: tests

commit efcb814
Author: Mateusz Russak <[email protected]>
Date:   Fri Nov 22 23:10:25 2024 +0100

    fix: linter error

commit a93b102
Author: Mateusz Russak <[email protected]>
Date:   Fri Nov 22 22:16:46 2024 +0100

    fix(WF-123): Fix writer versions in examples

commit 93a4f6e
Author: Mikita Makiej <[email protected]>
Date:   Mon Nov 18 12:47:27 2024 +0300

    fix: also include empty non-`None` content as failing condition

commit bb3683a
Author: Mikita Makiej <[email protected]>
Date:   Mon Nov 18 11:46:52 2024 +0300

    fix: unfinished docstring

commit 2f96977
Author: mmikita95 <[email protected]>
Date:   Mon Nov 18 10:51:13 2024 +0300

    chore: update `_is_serialized`

commit d646732
Author: mmikita95 <[email protected]>
Date:   Fri Nov 8 17:34:02 2024 +0400

    chore: serialize tool calls messages with non-empty content
madeindjs added a commit to madeindjs/writer-framework that referenced this pull request Dec 6, 2024
@madeindjs
fix(ui): fix Field align binding
d3e8a7e 
Fix a small regression from
writer#638 , the
`BuilderFieldsAlign` is not correctly binded to the `v-model` directive.
@madeindjs madeindjs mentioned this pull request Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@madeindjs madeindjs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madeindjs @ramedina86