fix: change logic for finish reason processing #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramedina86
added a commit
that referenced
this pull request
Nov 19, 2024
commit 202406d Merge: f7bd8e7 f571e48 Author: Ramiro Medina <[email protected]> Date: Tue Nov 19 10:18:54 2024 +0100 Merge pull request #636 from mmikita95/fix-tool-calls-finish-processing fix: change logic for finish reason processing commit f7bd8e7 Merge: b538673 0e379de Author: Ramiro Medina <[email protected]> Date: Tue Nov 19 09:55:16 2024 +0100 Merge pull request #637 from FabienArcellier/WF-80-clean-up-core chore: clean up core - WF-80 commit 0e379de Author: Fabien Arcellier <[email protected]> Date: Mon Nov 18 21:56:20 2024 +0100 chore: clean up core * chore: move dataframe dedicated method into core_df commit a30d46b Author: Fabien Arcellier <[email protected]> Date: Mon Nov 18 21:44:19 2024 +0100 chore: clean up core * chore: move all functions that start with writer_event_handler_* to EventHandlerExecutor class as static commit f571e48 Author: mmikita95 <[email protected]> Date: Mon Nov 18 13:15:56 2024 +0300 fix: change logic for finish reason processing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An error in logic required
finish_reason: "tool_calls"message to always havetool_calls: [...]object – which is possible in certain contexts, but not always true. This fix modifies the logic to detect thefinish_reasonindependently.