Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve performance in writing wf project - WF-97 #627

Conversation

FabienArcellier
Copy link
Collaborator

@FabienArcellier FabienArcellier commented Nov 11, 2024

Since the IDE information is stored in the .wf folder instead of ui.json, typing quickly in the WF IDE may experience latency.


The saving of editing files is carried out asynchronously in a dedicated process. It is no longer blocking. The time spent in the process is reduced to practically zero when making modifications in edit mode.

before (extract using py-spy), the operation of write_files use most of the CPU time.
image

after, the operation of write_files is not visible anymore. the CPU time consume by websocket stream is very low
image

@FabienArcellier FabienArcellier force-pushed the WF-97-improve-performance-in-writing-wf-project branch 3 times, most recently from f713a97 to 4e0620c Compare November 11, 2024 21:33
@FabienArcellier FabienArcellier added the bug Something isn't working label Nov 11, 2024
@FabienArcellier FabienArcellier self-assigned this Nov 11, 2024
@FabienArcellier FabienArcellier force-pushed the WF-97-improve-performance-in-writing-wf-project branch 3 times, most recently from 05cb3fa to 63a2021 Compare November 13, 2024 17:19
@FabienArcellier FabienArcellier force-pushed the WF-97-improve-performance-in-writing-wf-project branch from 63a2021 to dd14048 Compare November 13, 2024 17:29
This agent allows you to process the backup of .wf files in the background
without blocking application requests.

:param wf_project_save_interval: the interval in seconds to save the project files
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename this parameter

@FabienArcellier FabienArcellier marked this pull request as ready for review November 18, 2024 10:19
@ramedina86 ramedina86 merged commit 77c793e into writer:dev Nov 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants