-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add metadata for SEO and social media sharing - WF-77 #608
feat: add metadata for SEO and social media sharing - WF-77 #608
Conversation
src/writer/serve.py
Outdated
@@ -556,6 +559,78 @@ async def lifespan(app: FastAPI): | |||
async with _lifespan_invoke(writer_lifespans, app): | |||
yield | |||
|
|||
def configure_page_head( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename the function to something more explicit
- configure_app_seo
- configure_app_heads
- ...
Do you have proposal ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say configure_html_head
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
configure_webpage_metadata
b9ba3e8
to
f126497
Compare
* feat: implement configure_page_head signature
* feat: implement the settings
* feat: implement injection of meta and opengraph
* docs:write documentation about this feature
* fix: french in documentation * fix: escape variable before rendering html
* fix: change the name of the function into `configure_webpage_metadata`
fd3ad1c
to
517d59b
Compare
This PR implement a way to manage SEO and social media metadata.
server_setup.py
Now - Before