feat: add deploy alias #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raaymax any ideas on why the CI might be failing? |
|
No idea, it's failing the same way also in the other PR.. |
|
Found this microsoft/playwright#30368 |
|
It does, so how do we fix? cc @FabienArcellier |
|
Looks like it run this time though? |
madeindjs
approved these changes
Oct 20, 2024
src/writer/command_line.py
Outdated
| prompt="Enter your API key", | ||
| hide_input=True, help="Writer API key" | ||
| ) | ||
| @click.option('--env', '-e', multiple=True, default=[], help="Environment to deploy the app to") |
There was a problem hiding this comment.
Maybe Environments as it can be multiple
Suggested change
| @click.option('--env', '-e', multiple=True, default=[], help="Environment to deploy the app to") | |
| @click.option('--env', '-e', multiple=True, default=[], help="Environments to deploy the app to") |
There was a problem hiding this comment.
Aren't these environment variables?
|
You have no idea how much time I spent in click docs searching for exactly something like this... |
ramedina86
reviewed
Oct 22, 2024
Co-authored-by: Ramiro Medina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.