Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow CLI to find a different port - WF-76 #577

Conversation

FabienArcellier
Copy link
Collaborator

@FabienArcellier FabienArcellier commented Oct 2, 2024

implement #567

writer run

image

writer edit

image

does not look for the next port when port is set manually

image

@FabienArcellier FabienArcellier changed the title feat: allow CLI to find a different port feat: allow CLI to find a different port. WF-76 Oct 2, 2024
@FabienArcellier FabienArcellier added the enhancement New feature or request label Oct 2, 2024
@FabienArcellier FabienArcellier self-assigned this Oct 2, 2024
@FabienArcellier FabienArcellier force-pushed the 567-allow-cli-to-find-a-different-port branch from 864b841 to f65c402 Compare October 2, 2024 05:58
@FabienArcellier FabienArcellier marked this pull request as ready for review October 2, 2024 06:03
src/writer/serve.py Outdated Show resolved Hide resolved
docs/framework/quickstart-tutorial.mdx Outdated Show resolved Hide resolved
docs/framework/quickstart-tutorial.mdx Outdated Show resolved Hide resolved
@FabienArcellier FabienArcellier force-pushed the 567-allow-cli-to-find-a-different-port branch from f65c402 to 2e688d9 Compare October 2, 2024 16:20
@FabienArcellier FabienArcellier force-pushed the 567-allow-cli-to-find-a-different-port branch from 2e688d9 to 9b5479f Compare October 2, 2024 16:21
@FabienArcellier FabienArcellier changed the title feat: allow CLI to find a different port. WF-76 feat: allow CLI to find a different port - WF-76 Oct 2, 2024
@ramedina86 ramedina86 merged commit f3bd5b9 into writer:dev Oct 3, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants