feat: Component refactor and toolkit #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raaymax
approved these changes
Aug 29, 2024
madeindjs
approved these changes
Aug 29, 2024
madeindjs
reviewed
Aug 29, 2024
There was a problem hiding this comment.
Don't you think it should be placed in src/components/custom
There was a problem hiding this comment.
I didn't think it was urgent but yes, absolutely. I'll create a Jira ticket so that we don't forget.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the concept of "toolkit", namely:
core(collection of all the component templates we now until now, including Section, Page, etc)workflows(new collection for Workflows)It also updates the mode switcher so you can choose 4 modes:
A switch in mode determines which toolkit is shown; only the Workflows mode shows the
workflowstoolkit.There's also been a refactor in the
core_componentsfolder to allow for a neater hierarchy that can accommodate the two toolkits,coreandworkflows. Paths have been updated to use the "@/" syntax, since the relative syntax was getting out of hand i.e.../../../injectionKeysetc.