feat(ui): add filter to BuilderSidebarToolbar. WF-42
#516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madeindjs
force-pushed
the
WF-42
branch
2 times, most recently
from
9bed433 to
d2893be
Compare
I introduced a component named `BuilderSidebarTitleSearch` which extract the existing search logic of `BuilderSidebarTree` and use it for `BuilderSidebarToolbar`. I also took the opportunity to improve the accessibility since we use `<i>` elements as button, but they're not focusable and clickable with the keyboard. And finally, I introduced an E2E test which cover the new feature.
|
Looks great! Thanks for adding tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced a component named
BuilderSidebarTitleSearchwhich extract the existing search logic ofBuilderSidebarTreeand use it forBuilderSidebarToolbar.I also took the opportunity to improve the accessibility since we use
<i>elements as button, but they're not focusable and clickable with the keyboard.And finally, I introduced an E2E test which cover the new feature.
Screencast.from.2024-08-15.14-45-59.mp4