feat(ui): add icon to WdsTextInput. WF-36
#511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simply add `leftIcon` props to `WdsTextInput` and add a search icon to the dataframe component.
ramedina86
reviewed
Aug 12, 2024
| border: 1px solid var(--softenedAccentColor); | ||
| box-shadow: 0px 0px 0px 3px rgba(81, 31, 255, 0.05); | ||
| } | ||
|
|
||
| .WdsTextInput--leftIcon { |
There was a problem hiding this comment.
Hey I guess nothing wrong with it but just wanted to know, why do you do
.WdsTextInput--leftIcon
instead of
.WdsTextInput.leftIcon
It'd more compact since
class="WdsTextInput WdsTextInput--leftIcon"
becomes
class="WdsTextInput leftIcon"
Since the styles are scoped there's no risk of another leftIcon bothering you.
There was a problem hiding this comment.
It's just a habit of following BEM convention. It helps to improve the organization of the CSS. So the *--leftIcon acts as a "modifier". A modifier means to change appearance, behavior or state of an element.
But I agree that here, it's not necessary since the style is scoped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply add
leftIconprops toWdsTextInputand add a search icon to the dataframe component.Screencast.from.2024-08-08.22-07-19.mp4