Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): remove some overflow constraints #504

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

madeindjs
Copy link
Collaborator

CoreSelect displays a dropdown which is cropped by overflow: hidden. Removing this CSS rule prevent that

closes #380

Screencast.from.2024-07-30.20-47-37.mp4

@madeindjs madeindjs self-assigned this Jul 30, 2024
@madeindjs madeindjs marked this pull request as ready for review July 30, 2024 21:21
@ramedina86
Copy link
Collaborator

I think the rounded corners in the video you shared are broken, hence the overflow :(

`CoreSelect` displays a dropdown which is cropped by `overflow: hidden`. Removing this CSS rule prevent that

closes writer#380
@madeindjs
Copy link
Collaborator Author

@ramedina86 , it's fixed. I simply added border-bottom-left|right-radius to the container to avoid that (diff)

@ramedina86
Copy link
Collaborator

@madeindjs No idea that existed, brilliant! Thanks

@ramedina86 ramedina86 merged commit 77c8d41 into writer:dev Aug 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi choice dropdopw choices in a section does not show all options and is cutoff
2 participants