Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added redeploy confirmation if different app was already deployed using same api key #469

Closed
wants to merge 1 commit into from

Conversation

raaymax
Copy link
Collaborator

@raaymax raaymax commented Jun 19, 2024

No description provided.

@FabienArcellier
Copy link
Collaborator

FabienArcellier commented Jun 19, 2024

In this scenario, wouldn't it be simpler to use the absolute path of the folder that contains the application as a reference?

The only benefit of using app id is to support directory rename. If you go further in this direction, I would recommand to add it on the app provisionning or in the writer framework code, not in the deployment code.

alternate propsition that does not change the ui.json :

  • have a file deployments.json
{
  "<token>": "<absolute path of project>",
  "<token2>": "<absolute path of project 2>"
}
  • raise a warning when a token is already used for a path that is different from the previous one

@ramedina86
Copy link
Collaborator

Good to close this?

@raaymax raaymax closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants