feat: updated pdf component with highlights #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramedina86
reviewed
Feb 22, 2024
| cssClasses, | ||
| }, | ||
| events: { | ||
| "pdf-load": { |
There was a problem hiding this comment.
Is this event being fired? I can't seem to find the code that fires it.
Feel free to remove this event for now, but if you want to keep it:
- Make sure to trigger it
- Please rename this one to
ss-pdf-load. You shouldn't need to change the core if there's no payload. - Also, add a
deschere even if we suspect what is, just for consistency.
Note about "ss-" usage:
I strongly prefer to prefix "ss-" and use sanitisation when needed, but when basically forwarding events from other libraries e.g. Google Maps this is potentially a pain as you usually have complex types that can change across versions.
ramedina86
reviewed
Feb 22, 2024
|
Thanks for the changes and the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.