fix: introducing a fixture for proper teardown

[mmikita95]

Looks quite hellish in the diff, but essentially this adds a fixture to properly initiate an AppRunner (with dynamic parameters), and to shut it down during test teardown, to address the issue with AppRunner not being shut down if the test fails.

[ramedina86]

Nice. Thanks for seeing something that's wrong and doing something about it.

Yes, looks like the diff is mainly the result of the tabs for the context managers.

[FabienArcellier]

I would advocate to remove the dependence to pytest here, it's not required because we use it as a simple context manager. The boilerplate for pytest make that heavy and explicit dependency is better when we can.

with setup_app_runner("./not_an_app", "run") as ar:
  pass

[FabienArcellier]

and add the typing if you can

@contextlib.contextmanager
def setup_app_runner(app_dir: str, app_command: str):
    ar = AppRunner(app_dir, app_command)
    try:
        yield ar
    finally:
        ar.shut_down()

[FabienArcellier]

from conftest import setup_app_runner

def test_init_wrong_path(self) -> None:
    with setup_app_runner("./not_an_app", "run") as ar:
        with pytest.raises(SystemExit) as wrapped_e:
            ar.load()
        assert wrapped_e.type == SystemExit