fix: custom components build properly on windows #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just tested this, it works great, thank you! |
|
@FabienArcellier I found an issue using inputs with this branch, I will upload references today. |
Let me know about it when you can. |
FabienArcellier
force-pushed
the
20-custom-components-build-properly-on-windows
branch
from
ebaa9e9 to
c3acb92
Compare
* fix: rollup on windows need to use class import and don't have .ts as suffix
FabienArcellier
force-pushed
the
20-custom-components-build-properly-on-windows
branch
from
c3acb92 to
2d9e23c
Compare
FabienArcellier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solve the issue of custom components not building on windows (fix #192)