chore: changes according to code review

writer · Feb 19, 2024 · e68fb69 · e68fb69
1 parent 62583ad
commit e68fb69
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 25 deletions.
diff --git a/ui/package-lock.json b/ui/package-lock.json
diff --git a/ui/package.json b/ui/package.json
@@ -36,6 +36,6 @@
 		"prettier": "^3.0.1",
 		"vite": "^4.4.9",
 		"vite-plugin-monaco-editor": "^1.1.0",
-		"volar-service-vetur": "latest"
+		"volar-service-vetur": "*"
 	}
 }
diff --git a/ui/src/core_components/embeds/CoreGoogleMaps.vue b/ui/src/core_components/embeds/CoreGoogleMaps.vue
@@ -125,32 +125,28 @@ const buildMarkers = async () => {
 	if (!fields.markers.value) return;
 	const { AdvancedMarkerElement } = await google.maps.importLibrary("marker") as google.maps.MarkerLibrary;
 	clearMarkers();
-	try {
-		const markersData = fields.markers.value as ({ lat: number; lng: number; name: string; }[])
-		markersData.forEach((markerData) => {
-			const marker = new AdvancedMarkerElement({
-				position: {
-					lat: markerData.lat,
-					lng: markerData.lng,
-				},
-				map,
-				title: markerData.name,
-			});
+	const markersData = fields.markers.value as ({ lat: number; lng: number; name: string; }[])
+	markersData.forEach((markerData) => {
+		const marker = new AdvancedMarkerElement({
+			position: {
+				lat: markerData.lat,
+				lng: markerData.lng,
+			},
+			map,
+			title: markerData.name,
+		});
 
-			markers.push(marker);
+		markers.push(marker);
 
-			marker.addListener('click', () => {
-				const event = new CustomEvent("gmap-marker-click", {
-					detail: {
-						payload: markerData,
-					},
-				});
-				rootEl.value.dispatchEvent(event);
+		marker.addListener('click', () => {
+			const event = new CustomEvent("gmap-marker-click", {
+				detail: {
+					payload: markerData,
+				},
 			});
+			rootEl.value.dispatchEvent(event);
 		});
-	} catch (e) {
-		console.log(e);
-	}
+	});
 };
 
 const clearMarkers = () => {
@@ -214,7 +210,6 @@ watch(fields.mapId, initMap);
   left: 0;
   width: 100%;
   height: 100%;
-  background-color: rgba(0, 0, 0, 0);
 }
 
 .CoreGoogleMaps.beingEdited.selected .mask {