fix update table when searching in the dataframe

writer · Sep 19, 2024 · 8d2b5ee · 8d2b5ee
1 parent 605f4b1
commit 8d2b5ee
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/ui/src/components/core/content/CoreDataframe.vue b/src/ui/src/components/core/content/CoreDataframe.vue
@@ -560,7 +560,12 @@ async function handleSearchChange(ev: InputEvent) {
 			columnNames
 				.map((c) => `aq.op.match(d.${c}, $.pattern) !== null`)
 				.join(" || ");
-		table.value = baseTable.params({ pattern, filterS }).filter(filterS);
+
+		const aq = await import("arquero");
+		table.value = baseTable
+			.params({ pattern, filterS })
+			.filter(filterS)
+			.derive({ [ARQUERO_INTERNAL_ID]: () => aq.op.row_number() });
 	}
 	await nextTick();
 	resetScroll();

diff --git a/src/ui/src/components/core/content/CoreDataframe/useDataframeValueBroker.ts b/src/ui/src/components/core/content/CoreDataframe/useDataframeValueBroker.ts
@@ -109,6 +109,8 @@ export function useDataFrameValueBroker(
 		value: unknown,
 	) {
 		if (!table.value) throw Error("Table is not ready");
+		if (rowIndex === undefined)
+			throw Error("Must specify the index to update a row");
 		const eventType = "wf-dataframe-update";
 		const rowIndexBackend = rowIndex - 1; // 0-based index (arquero is based on 1-based index)