Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated java plugin conventions #602

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

lhvy
Copy link
Contributor

@lhvy lhvy commented Aug 24, 2023

Now that WPILib has decided to use Gradle 8.x, there are deprecation warnings in the default build.gradle files in project templates/examples. The following PR fixes the deprecation warnings. (More detail here)

I have also bumped the Java version now too.

@lhvy lhvy changed the title Fix deprecated java plugin conventions Fix deprecated java plugin conventions and bump Java version Aug 24, 2023
@lhvy
Copy link
Contributor Author

lhvy commented Aug 24, 2023

The same setting did not exist in vscode-wpilib/resources/gradle/javadt/build.gradle. Does this need to be updated/fixed as well?

@sciencewhiz
Copy link
Contributor

I think bumping to 17 should be a different PR. We'd definitely want to fix the deprecation warning. I think it's still undecided whether to bump to 17 compatibility. See https://www.chiefdelphi.com/t/wpilib-blog-2023-kickoff-release-of-wpilib/420683/6 for the initial reasoning. Given that some teams reported GC problems last year, it seems like it may be prudent to keep it another year while alternate GC options are explored.

@lhvy lhvy changed the title Fix deprecated java plugin conventions and bump Java version Fix deprecated java plugin conventions Aug 25, 2023
@lhvy
Copy link
Contributor Author

lhvy commented Aug 25, 2023

I think bumping to 17 should be a different PR.

Fixed. Thanks for the feedback! :)

@PeterJohnson
Copy link
Member

I actually merged the 17 change first. So this needs fixing up. We also recently added a javaxrp template so it should have the same change I assume.

sciencewhiz added a commit to Beachbot330/RobotBuilder that referenced this pull request Sep 2, 2023
PeterJohnson pushed a commit to wpilibsuite/RobotBuilder that referenced this pull request Sep 2, 2023
@lhvy
Copy link
Contributor Author

lhvy commented Sep 2, 2023

I actually merged the 17 change first. So this needs fixing up. We also recently added a javaxrp template so it should have the same change I assume.

Fixed, including to the new template you mentioned. Do I need to do this for vscode-wpilib/resources/gradle/javadt/build.gradle as well?

@PeterJohnson
Copy link
Member

Yes please fix all the instances, thanks!

@lhvy
Copy link
Contributor Author

lhvy commented Sep 6, 2023

Yes please fix all the instances, thanks!

Done 👍

@PeterJohnson PeterJohnson merged commit 127a0c1 into wpilibsuite:main Sep 12, 2023
6 checks passed
wpineth added a commit to wpineth/vscode-wpilib that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants