-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecated java plugin conventions #602
Conversation
The same setting did not exist in |
I think bumping to 17 should be a different PR. We'd definitely want to fix the deprecation warning. I think it's still undecided whether to bump to 17 compatibility. See https://www.chiefdelphi.com/t/wpilib-blog-2023-kickoff-release-of-wpilib/420683/6 for the initial reasoning. Given that some teams reported GC problems last year, it seems like it may be prudent to keep it another year while alternate GC options are explored. |
Fixed. Thanks for the feedback! :) |
I actually merged the 17 change first. So this needs fixing up. We also recently added a javaxrp template so it should have the same change I assume. |
Matches wpilibsuite/vscode-wpilib#591 Fixes deprecation matching wpilibsuite/vscode-wpilib#602
Matches wpilibsuite/vscode-wpilib#591 Fixes deprecation matching wpilibsuite/vscode-wpilib#602
Fixed, including to the new template you mentioned. Do I need to do this for |
Yes please fix all the instances, thanks! |
Done 👍 |
Now that WPILib has decided to use Gradle 8.x, there are deprecation warnings in the default
build.gradle
files in project templates/examples. The following PR fixes the deprecation warnings. (More detail here)I have also bumped the Java version now too.