Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use junit-bom for JUnit dependencies. #570

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Javaru
Copy link

@Javaru Javaru commented Dec 27, 2022

With the changed to using JUnit 5 in 2023, it would be preferable to use the junit-bom for managing all JUnit dependencies.

BOM (Bill of Materials) files make version management easier -- since when upgrading JUnit, a version number change is only needed in one place -- and ensure a consistent version of JUnit artifacts are used throughout the project, even when pulled in transitively. For example, if a user where to add an additional testing library or framework that transitively pulls in (as an example) version 5.6.3 of junit-vintage-engine, the BOM would result in that being upgraded to the same version as the BOM, v5.8.2 in this example. Without the BOM, version 5.6.2 of junit-vintage-engine would get used, resulting in a mismatch of JUnit artifacts.

References:

@PeterJohnson
Copy link
Member

We need to understand how this interacts with the installer, which needs to grab specific artifact versions for offline installation.

@ThadHouse
Copy link
Member

I think this would work, but since we're not doing another beta cycle, I'd be worried about doing this so late. I think this might need to be a 2024 thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants