Add XRP to creating robot programs #2760
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasondaming
requested changes
Sep 28, 2024
|
|
||
| #### XRP - Timed | ||
|
|
||
| The ``XRP - Timed`` template provides a ``XRPDrivetrain`` class that exposes an ``arcadeDrive(double xaxisSpeed, double zaxisRotate)`` method. It's up to the user to feed this arcadeDrive function. |
There was a problem hiding this comment.
We should be exact with the naming here. It looks like they are called XRP - Command Robot and XRP - Timed Robot. This is also a problem with the Romi section. I realize you didn't write that but I think improving it the same way would help!
|
|
||
| The ``XRP - Command Bot`` template provides a ``XRPDrivetrain`` subsystem that exposes an ``arcadeDrive(double xaxisSpeed, double zaxisRotate)`` method. It's up to the user to feed this arcadeDrive function. | ||
|
|
||
| This subsystem also provides functions for retrieving and resetting the XRP's onboard encoders. |
There was a problem hiding this comment.
All of this feels just a duplication of the Romi stuff. While it is all true I am wondering if we couldn't get across all the same information with a single combined section that use this text once for all. It would need to say "subsystem/class".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.