-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmd] Fix proxy command deprecation docs #7396
base: main
Are you sure you want to change the base?
[cmd] Fix proxy command deprecation docs #7396
Conversation
This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR. |
C++ has another constructor that needs changed |
43c7863
to
ca33449
Compare
/format |
CI failure seems to be unrelated. |
Not applicable to python, the deprecation message is different. |
Just remembered, the other thing that needs fixed is the docs for |
I'd be inclined to undeprecate deferred proxy and leave it with the new implementation. I feel it accurately describes what its syntactic sugar over |
wpilibNewCommands/src/main/native/include/frc2/command/ProxyCommand.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use "proxy a deferred command" in the C++ docs like we do in Java? (Also, while we're here, it might be nice to link to command factories in adddition to the command class)
You'll notice this updates the Java documentation as well, that documentation was wrong and did not give the correct behaviour. This change corrects it to give accurate behaviour
Yes I plan to do this but I'll also have to undeprecate deferredProxy first :) |
Signed-off-by: Jade Turner <[email protected]>
c2b20f2
to
1ef60e4
Compare
Sorry I got the order wrong when writing on mobile, but the changed Java docs say "defer a proxy command", not "use defer command on a proxy command". Regardless of which one we use, it should be consistent between Java and C++. (And my vote is for the Java version since it's less tied to the particular command types) |
No description provided.