Skip to content

Commit

Permalink
Remove Python scripts for launching applications (#459)
Browse files Browse the repository at this point in the history
Resolves #437.

Signed-off-by: Jade Turner <[email protected]>
  • Loading branch information
spacey-sooty authored Oct 19, 2024
1 parent 28900e5 commit 52bc77e
Show file tree
Hide file tree
Showing 9 changed files with 0 additions and 229 deletions.
9 changes: 0 additions & 9 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -129,18 +129,9 @@ jobs:
- uses: actions/setup-dotnet@v4
with:
dotnet-version: 8.x
- uses: actions/setup-python@v5
with:
python-version: 3.8

- name: Install black
run: pip3 install black

- name: Run dotnet format
run: dotnet format

- name: Run black
run: black .

- name: Verify formatters made no changes
run: git --no-pager diff --exit-code HEAD
2 changes: 0 additions & 2 deletions apps/ToolsUpdater/src/main/java/Program.java
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ private static void installJavaTool(ToolConfig tool, String toolsPath) {
if (SystemUtils.IS_OS_WINDOWS) {
Files.copy(Paths.get(toolsPath, "ScriptBase.vbs"), Paths.get(toolsPath, tool.name + ".vbs"), StandardCopyOption.REPLACE_EXISTING, StandardCopyOption.COPY_ATTRIBUTES);
} else {
Files.copy(Paths.get(toolsPath, "ScriptBase.py"), Paths.get(toolsPath, tool.name + ".py"), StandardCopyOption.REPLACE_EXISTING, StandardCopyOption.COPY_ATTRIBUTES);
Files.copy(Paths.get(toolsPath, "ScriptBase.sh"), Paths.get(toolsPath, tool.name + ".sh"), StandardCopyOption.REPLACE_EXISTING, StandardCopyOption.COPY_ATTRIBUTES);
}
} catch (IOException e) {
Expand Down Expand Up @@ -86,7 +85,6 @@ private static void installCppTool(ToolConfig tool, String toolsPath) {
if (SystemUtils.IS_OS_WINDOWS) {
Files.copy(Paths.get(toolsPath, "ScriptBaseCpp.vbs"), Paths.get(toolsPath, tool.name + ".vbs"), StandardCopyOption.REPLACE_EXISTING, StandardCopyOption.COPY_ATTRIBUTES);
} else {
Files.copy(Paths.get(toolsPath, "ScriptBaseCpp.py"), Paths.get(toolsPath, tool.name + ".py"), StandardCopyOption.REPLACE_EXISTING, StandardCopyOption.COPY_ATTRIBUTES);
Files.copy(Paths.get(toolsPath, "ScriptBaseCpp.sh"), Paths.get(toolsPath, tool.name + ".sh"), StandardCopyOption.REPLACE_EXISTING, StandardCopyOption.COPY_ATTRIBUTES);
}

Expand Down
29 changes: 0 additions & 29 deletions files/AdvantageScope.py

This file was deleted.

43 changes: 0 additions & 43 deletions files/MavenMetaDataFixer.py

This file was deleted.

43 changes: 0 additions & 43 deletions files/ScriptBase.py

This file was deleted.

29 changes: 0 additions & 29 deletions files/ScriptBaseCpp.py

This file was deleted.

43 changes: 0 additions & 43 deletions files/ToolsUpdater.py

This file was deleted.

12 changes: 0 additions & 12 deletions scripts/installer.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,8 @@ evaluationDependsOn(':apps:MavenMetaDataFixer')
evaluationDependsOn(':apps:ToolsUpdater')

def metaDataScriptBatch = file("$rootDir/files/MavenMetaDataFixer.bat")
def metaDataScriptPy = file("$rootDir/files/MavenMetaDataFixer.py")
def metaDataScriptSh = file("$rootDir/files/MavenMetaDataFixer.sh")
def toolsUpdaterBatch = file("$rootDir/files/ToolsUpdater.bat")
def toolsUpdaterPy = file("$rootDir/files/ToolsUpdater.py")
def toolsUpdaterSh = file("$rootDir/files/ToolsUpdater.sh")

ext.msBuildExtraSetup = { AbstractArchiveTask zip->
Expand All @@ -17,10 +15,8 @@ ext.msBuildExtraSetup = { AbstractArchiveTask zip->
zip.inputs.file project(':apps:ToolsUpdater').shadowJar.archivePath
zip.inputs.file metaDataScriptBatch
zip.inputs.file metaDataScriptSh
zip.inputs.file metaDataScriptPy
zip.inputs.file toolsUpdaterBatch
zip.inputs.file toolsUpdaterSh
zip.inputs.file toolsUpdaterPy

zip.dependsOn project(':apps:MavenMetaDataFixer').shadowJar
zip.dependsOn project(':apps:ToolsUpdater').shadowJar
Expand All @@ -35,10 +31,6 @@ ext.msBuildExtraSetup = { AbstractArchiveTask zip->
into '/maven'
fileMode 0755
}
zip.from(metaDataScriptPy) {
into '/maven'
fileMode 0755
}
} else {
zip.from(metaDataScriptBatch) {
into '/maven'
Expand All @@ -55,10 +47,6 @@ ext.msBuildExtraSetup = { AbstractArchiveTask zip->
into '/tools'
fileMode 0755
}
zip.from(toolsUpdaterPy) {
into '/tools'
fileMode 0755
}
} else {
zip.from(toolsUpdaterBatch) {
into '/tools'
Expand Down
19 changes: 0 additions & 19 deletions scripts/tools.gradle
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
def toolsJson = file("$buildDir/tools.json")
def scriptBaseFile = file("files/ScriptBase.vbs")
def scriptBasePythonFile = file("files/ScriptBase.py")
def scriptBaseUnixFile = file("files/ScriptBase.sh")

def scriptBaseCppFile = file("files/ScriptBaseCpp.vbs")
def scriptBaseCppPythonFile = file("files/ScriptBaseCpp.py")
def scriptBaseCppUnixFile = file("files/ScriptBaseCpp.sh")

def advantageScopeScriptFile = file("files/AdvantageScope.vbs")
def advantageScopeScriptPythonFile = file("files/AdvantageScope.py")
def advantageScopeScriptUnixFile = file("files/AdvantageScope.sh")

def choreoScriptFile = file("files/Choreo.vbs")
Expand Down Expand Up @@ -90,7 +87,6 @@ ext.toolsSetup = { AbstractArchiveTask zip->
zip.inputs.file toolsJson
zip.inputs.file scriptBaseFile
zip.inputs.file scriptBaseUnixFile
zip.inputs.file scriptBasePythonFile

zip.from (toolsJson) {
into '/tools'
Expand Down Expand Up @@ -118,31 +114,16 @@ ext.toolsSetup = { AbstractArchiveTask zip->
fileMode 0755
}

zip.from (scriptBasePythonFile) {
into '/tools'
fileMode 0755
}

zip.from (scriptBaseCppUnixFile) {
into '/tools'
fileMode 0755
}

zip.from (scriptBaseCppPythonFile) {
into '/tools'
fileMode 0755
}

zip.from (advantageScopeScriptUnixFile) {
into '/tools'
fileMode 0755
}

zip.from (advantageScopeScriptPythonFile) {
into '/tools'
fileMode 0755
}

zip.from (choreoScriptUnixFile) {
into '/tools'
fileMode 0755
Expand Down

0 comments on commit 52bc77e

Please sign in to comment.