Update to gradle 8.11 #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes much nicer warning APIs. Includes a lot of deperecations, so we need to test things
sciencewhiz
reviewed
Nov 17, 2024
| @@ -52,6 +52,10 @@ allprojects { | |||
| tasks.withType(Javadoc) { | |||
| options.addBooleanOption('Xdoclint:all,-missing', true) | |||
| } | |||
|
|
|||
| tasks.withType(JavaCompile) { | |||
| options.compilerArgs << "-Xlint:unchecked" << "-Xlint:deprecation" | |||
There was a problem hiding this comment.
No. We want to add these. I'm surprised they were not here before.
sciencewhiz
added a commit
to sciencewhiz/vscode-wpilib
that referenced
this pull request
Nov 17, 2024
Needs wpilibsuite/GradleRIO#761 to avoid deprecation warnings
sciencewhiz
added a commit
to Beachbot330/RobotBuilder
that referenced
this pull request
Nov 17, 2024
Needs wpilibsuite/GradleRIO#761 to avoid deprecation warnings Matches wpilibsuite/vscode-wpilib#724
src/main/java/edu/wpi/first/gradlerio/deploy/roborio/FRCJNILibraryArtifact.java
Show resolved
Hide resolved
src/main/java/edu/wpi/first/gradlerio/wpi/dependencies/WPIDependenciesPlugin.java
Show resolved
Hide resolved
| @@ -18,7 +17,7 @@ public class WPICppTool implements Named { | |||
| private final Provider<String> version; | |||
|
|
|||
| public WPICppTool(Project project, String name, Provider<String> version, String artifactId, Provider<Directory> toolsFolder) { | |||
| Configuration config = project.getConfigurations().getByName("wpiCppTools"); | |||
| //Configuration config = project.getConfigurations().getByName("wpiCppTools"); | |||
There was a problem hiding this comment.
Commented-out code should be removed?
There was a problem hiding this comment.
I want to keep this for when we finally getting around to adding installation for C++ tools.
PeterJohnson
previously approved these changes
Nov 18, 2024
|
@PeterJohnson I need to merge native uitils and publish that for use here before merging. |
PeterJohnson
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes much nicer warning APIs. Includes a lot of deperecations, so we need to test things