This repository has been archived by the owner on Apr 2, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Fix height calculations for Instagram responsive embeds #195
Open
goldenapples
wants to merge
8
commits into
master
Choose a base branch
from
194-instagram-responsive-embeds
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Dec 9, 2016
-
Add "height-adjust" to responive elements script
Because from iframes, like Instagram embeds, have a non-responsive element (header + footer) as well as the responsive part (the image), it would be helpful to be able to specify the two separately. This adds an additional data-element (data-height-adjust) which can be specified on the .shortcake-bakery-responsive element. If this is set, that portion of the height will be considered "static" and will not be recalculated on resize.
Configuration menu - View commit details
-
Copy full SHA for d12c833 - Browse repository at this point
Copy the full SHA d12c833View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8cb864 - Browse repository at this point
Copy the full SHA c8cb864View commit details
Commits on Dec 10, 2016
-
Update height calculations to include height-adjust
Try to match the padding from the wrapper div in the initial embed code, and use it to set the "ratio" on the shortcode. Leaves the "ratio" argument out if it's 100%.
Configuration menu - View commit details
-
Copy full SHA for fdcd311 - Browse repository at this point
Copy the full SHA fdcd311View commit details -
Satisfies minimum requirements for wp-coding-standards @Dev-Master.
Configuration menu - View commit details
-
Copy full SHA for b0bb3aa - Browse repository at this point
Copy the full SHA b0bb3aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for c744cf5 - Browse repository at this point
Copy the full SHA c744cf5View commit details -
Fix some phpcs issues preventing build from passing
Mostly whitespace cleanup and the like...
Configuration menu - View commit details
-
Copy full SHA for 2e079ac - Browse repository at this point
Copy the full SHA 2e079acView commit details
Commits on Dec 13, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 2771a8b - Browse repository at this point
Copy the full SHA 2771a8bView commit details -
tfw phpcs has two conflicting rules applied to one line...
Configuration menu - View commit details
-
Copy full SHA for 14ce417 - Browse repository at this point
Copy the full SHA 14ce417View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.