Add optimization for Contact Form 7 #6215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release v3.14.4
Release v3.14.4.1
Release v3.14.4.2
Release 3.15
Release v3.15.0.1
Onload load Contact Form 7’s JavaScript if a form is present on the page.
Release v3.15.2
…lugin * Use template_redirect action rather than wp to prevent accidental admin usage. * Add version check for CF7. * Add conditional enqueueing for styles in addition to scripts. * Override filters for wpcf7_load_js and wpcf7_load_css to return false. * Prevent re-enqueueing scripts after they have been enqueued.
westonruter
force-pushed
the
add/contact-form-7-optimization
branch
from
6284813 to
6ece016
Compare
|
Note this PR incorporates optimizations from a standalone mini plugin. This was developed to fix rocklobster-in/contact-form-7#1278 in which scripts and styles for CF7 are enqueued on every page even when there is no contact form present. |
# Conflicts: # inc/ThirdParty/ServiceProvider.php
remyperona
approved these changes
Nov 20, 2023
Mai-Saad
approved these changes
Nov 27, 2023
wordpressfan
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Thanks @adamsilverstein , this is a great honor working with u on the same PR.
We will merge this PR but we need to revisit it to add tests and also change it a bit to have the callbacks registering inside the method get_subscribed_events after adding the bailout conditions there and small code formatting concepts that we use here like bailout early.
But the PR itself is good and working perfectly.
|
Thanks everyone for the attention on this, great to see this merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only load Contact Form 7’s JavaScript if a form is present on the page.
Description
The Contact Form 7 ("CF7") specific optimization ensures that CF7 front end scripts are only enqueued when the page contains a contact form.
fixes #6241
Type of change
Is the solution different from the one proposed during the grooming?
Please describe in this section if there is any change to the groomed solution, and why.
Checklists
Generic development checklist
Test summary
If not, detail what you could not test.
Please describe any additional tests you performed.