Add launchpad (Closes #133) #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CrochetFeve0251 Can you tell why the framework looks loaded twice?
|
@nicomollet the issue with the above code is that you included a subscriber twice. |
|
Sure I will look into it @CrochetFeve0251 |
Updated WP tested up to: 6.5.5
CrochetFeve0251
requested changes
Jul 2, 2024
src/Admin/AdminPage.php
Outdated
| @@ -58,22 +41,19 @@ class AdminPage | |||
| * | |||
| * @var string | |||
| */ | |||
| private $template_path; | |||
| private string $template_path; | |||
There was a problem hiding this comment.
@nicomollet I think this typing wasn't available in php 7.3
|
✅ Tested with PHP:
|
CrochetFeve0251
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #133
RLL adapted to Launchpad structure