Closes #939: Handle image stats through background processing #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyperona
reviewed
Dec 18, 2024
Comment on lines
+21
to
+26
| 'imagify_count_attachments_as', | ||
| 'imagify_count_error_attachments_as', | ||
| 'imagify_count_optimized_attachments_as', | ||
| 'imagify_count_saving_data_as', | ||
| 'imagify_calculate_total_size_images_library_as', | ||
| 'imagify_calculate_average_size_images_per_month_as', |
There was a problem hiding this comment.
Is there a reason you have the _as suffix for the actions?
| * | ||
| * @var string | ||
| */ | ||
| protected $stats_option = 'imagify_admin_stats'; |
There was a problem hiding this comment.
I'm thinking this naming is not very accurate, what do you think about imagify_attachments_stats or imagify_media_stats instead?
| * | ||
| * @return void | ||
| */ | ||
| public function imagify_count_attachments(): void { |
There was a problem hiding this comment.
You can remove the imagify_ prefix from the functions you copied since they're in a class now
| * @param integer $default default value to return. | ||
| * @return mixed | ||
| */ | ||
| function imagify_get_admin_stats( string $key, $default = 0 ) { |
There was a problem hiding this comment.
In relation to the option name change suggested, might be better to use imagify_get_attachments_stats or imagify_get_media_stats
|
As discussed yesterday, @jeawhanlee should this be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #939
Fixes issue with time out when collating stats.
Type of change
Detailed scenario
Explained here
Technical description
Documentation
Moves the stats logic from main thread to process in background using Action Scheduler.
New dependencies
N/A
Risks
Displayed stats will not be updated until the next scheduled action in this case 24hr
Mandatory Checklist
Code validation
Code style
Unticked items justification
If some mandatory items are not relevant, explain why in this section.
Additional Checks