Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #934 Incorrect display of infinite spelling on plan modal #940

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

Khadreal
Copy link
Contributor

Description

Fixes #934
Remove incorrect spelling of plan in the pricing modal box

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Detailed scenario

Check for #934 for detailed scenario

Technical description

Documentation

Added a string replace in JS to make sure the correct spelling of plan is display.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

This doesn't require any test as it's text related,

@Khadreal Khadreal self-assigned this Dec 12, 2024
@Khadreal Khadreal requested a review from a team December 12, 2024 11:42
Copy link
Contributor

@jeawhanlee jeawhanlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected
Screenshot 2024-12-12 at 13 54 56

@remyperona remyperona added this to the 2.2.4 milestone Dec 12, 2024
Copy link

@hanna-meda hanna-meda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Khadreal for this PR.
Confirming it as fixed: name is now correct (see screenshot ^).

@hanna-meda hanna-meda added this pull request to the merge queue Dec 16, 2024
Merged via the queue into develop with commit 7e076a5 Dec 16, 2024
8 checks passed
@hanna-meda hanna-meda deleted the fix/934-incorrect-display-of-plan branch December 16, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect display of infinite spelling on plan modal
4 participants