Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #932: update plugin family package #933

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jeawhanlee
Copy link
Contributor

Description

Update the plugin family package to the latest version.

Fixes #(issue number)
New package version handles translations.

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

Issue is currently visible on trunk

Technical description

Documentation

The new version of the package handles translation using the translation functions and some configurations in the composer.json file to update the package with the correct text domain.

New dependencies

N/A

Risks

N/A

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

Not applicable for this PR

Additional Checks

  • In the case of complex code, I wrote comments to explain it.
  • When possible, I prepared ways to observe the implemented system (logs, data, etc.).
  • I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

@jeawhanlee jeawhanlee self-assigned this Nov 29, 2024
@jeawhanlee jeawhanlee linked an issue Nov 29, 2024 that may be closed by this pull request
@jeawhanlee jeawhanlee requested a review from a team November 29, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update plugin family package
3 participants