Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #880 Update tests base #925

Merged
merged 18 commits into from
Nov 21, 2024
Merged

Closes #880 Update tests base #925

merged 18 commits into from
Nov 21, 2024

Conversation

remyperona
Copy link
Contributor

@remyperona remyperona commented Nov 20, 2024

Description

Fixes #880

Type of change

  • Chore

Detailed scenario

No scenario necessary, this is only changing testing code.

Technical description

Documentation

Update the tests base to use the v3 of our PHPUnit library, to bring it up to par with our other plugins.

New dependencies

wp-media/phpunit: 3

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

@remyperona remyperona self-assigned this Nov 20, 2024
@remyperona remyperona marked this pull request as ready for review November 20, 2024 14:24
@remyperona remyperona requested a review from a team November 20, 2024 14:24
@remyperona remyperona added this pull request to the merge queue Nov 21, 2024
Merged via the queue into develop with commit 49c5593 Nov 21, 2024
8 checks passed
@remyperona remyperona deleted the chore/update-tests-base branch November 21, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Unit Test to Imagify
2 participants