Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #912 imagify gets hidden in admin bar when click save and go to bulk optimizer #914

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

Khadreal
Copy link
Contributor

@Khadreal Khadreal commented Nov 1, 2024

Description

Fixes #912
Default admin bar menu to active

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Detailed scenario

Check #912 for scenario on how to reproduce

Technical description

Documentation

Set the checkbox to true for all users.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.

@Khadreal Khadreal self-assigned this Nov 1, 2024
@Khadreal Khadreal requested a review from a team November 1, 2024 11:31
Copy link

@hanna-meda hanna-meda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Khadreal, for this PR.
Everything looks good on fresh install, update, update while Imagify was hidden in top bar, enabling options, bulk optimization.
Confirming #912 fixed by this PR.

@Mai-Saad Mai-Saad added this pull request to the merge queue Nov 4, 2024
Merged via the queue into develop with commit 8737aff Nov 4, 2024
5 checks passed
@Mai-Saad Mai-Saad deleted the fix/912-imagify-gets-hidden branch November 4, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

imagify gets hidden in admin bar when click save and go to bulk optimizer
4 participants