-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #2883: Imagify Plugin - Replace the documentation link with the upgrade one for Free users #900
Merged
remyperona
merged 25 commits into
develop
from
enhancement/2883-replace-doc-link-with-upgrade-for-free-users
Oct 4, 2024
Merged
Closes #2883: Imagify Plugin - Replace the documentation link with the upgrade one for Free users #900
remyperona
merged 25 commits into
develop
from
enhancement/2883-replace-doc-link-with-upgrade-for-free-users
Oct 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khadreal
approved these changes
Sep 26, 2024
remyperona
reviewed
Sep 26, 2024
remyperona
requested changes
Sep 26, 2024
remyperona
approved these changes
Sep 30, 2024
@marija-nikolic Here are screenshots after the change (looks good to me) Notes:
|
Thanks. Can we please update the color to #6f9c3b (to improve visibility)? |
remyperona
deleted the
enhancement/2883-replace-doc-link-with-upgrade-for-free-users
branch
October 4, 2024 16:37
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://github.com/wp-media/imagify/issues/2883
Users on starter plan will see link to upgrade from the plugin page.
Type of change
Detailed scenario
N/A
Technical description
Documentation
Replaces the documentation link with the upgrade link in the plugin action links if the plan_id = 1
New dependencies
N/A
Risks
N/A
Mandatory Checklist
Code validation
Code style