Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2883: Imagify Plugin - Replace the documentation link with the upgrade one for Free users #900

Conversation

jeawhanlee
Copy link
Contributor

Description

Fixes https://github.com/wp-media/imagify/issues/2883
Users on starter plan will see link to upgrade from the plugin page.

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

N/A

Technical description

Documentation

Replaces the documentation link with the upgrade link in the plugin action links if the plan_id = 1

New dependencies

N/A

Risks

N/A

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I did not introduce unnecessary complexity.

@jeawhanlee jeawhanlee marked this pull request as ready for review September 25, 2024 19:22
@jeawhanlee jeawhanlee requested a review from a team September 25, 2024 19:22
inc/classes/class-imagify-views.php Outdated Show resolved Hide resolved
@Mai-Saad
Copy link

Mai-Saad commented Oct 1, 2024

@marija-nikolic Here are screenshots after the change (looks good to me)

  • starter plan
    Screenshot from 2024-10-01 14-40-52

  • growth plan
    growth

  • infinite plan
    infinite

Notes:

  • upgrade link is working
  • translations aren't handled here

@marija-nikolic
Copy link
Collaborator

@marija-nikolic Here are screenshots after the change (looks good to me)

  • starter plan
    Screenshot from 2024-10-01 14-40-52
  • growth plan
    growth
  • infinite plan
    infinite

Notes:

  • upgrade link is working
  • translations aren't handled here

Thanks. Can we please update the color to #6f9c3b (to improve visibility)?

@remyperona
Copy link
Contributor

Updated screenshot

upgrade

@marija-nikolic
Copy link
Collaborator

Updated screenshot

upgrade

Thank you, it seems more visible now.

@remyperona remyperona added this pull request to the merge queue Oct 4, 2024
Merged via the queue into develop with commit 75c1aa7 Oct 4, 2024
6 checks passed
@remyperona remyperona deleted the enhancement/2883-replace-doc-link-with-upgrade-for-free-users branch October 4, 2024 16:37
@remyperona remyperona mentioned this pull request Oct 11, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants