Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/readme update august 2024 makreting #896

Merged

Conversation

MathieuLamiot
Copy link
Contributor

Description

Applies the changes highlighted in yellow from this file to the readme.txt: https://docs.google.com/document/d/1zkGwSShnHvNNDjg7xXMLzvZcCWUxEstrtSMDTyQPIIo/edit

Type of change

  • New feature (non-breaking change which adds functionality).
  • Bug fix (non-breaking change which fixes an issue).
  • Enhancement (non-breaking change which improves an existing functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as before).
  • Sub-task of #(issue number)
  • Release

Detailed scenario

NA

Technical description

Documentation

NA

New dependencies

NA

Risks

NA

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Additional Checks

  • In the case of complex code, I wrote comments to explain it.
  • When possible, I prepared ways to observe the implemented system (logs, data, etc.).
  • I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

@MathieuLamiot MathieuLamiot self-assigned this Aug 27, 2024
@MathieuLamiot MathieuLamiot added this pull request to the merge queue Aug 28, 2024
Merged via the queue into develop with commit 895d74f Aug 28, 2024
6 checks passed
@MathieuLamiot MathieuLamiot deleted the enhancement/readme-update-august-2024-makreting branch August 28, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant