Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Next-Gen gallery compatibility for AVIF support #846

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

remyperona
Copy link
Contributor

Description

Update Next-Gen gallery compatibility for AVIF support

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.

@remyperona remyperona requested a review from a team March 6, 2024 22:33
@remyperona remyperona self-assigned this Mar 6, 2024
@piotrbak piotrbak added this to the 2.2.1 milestone Mar 7, 2024
@Mai-Saad
Copy link

Mai-Saad commented Mar 19, 2024

Exploratory test notes
Next-gen gallery plugin
Already on 2.1.3 (may need separate GH)
1- At next gen gallery, expand /collapse view details isnot working
2- Click restore original image, then click optimize again, will show that image is already optimized instead of optimizing it (tested with large image, and with med image but with medium image webP won't be created for main image 'only for thumb' while delete webp option is displayed in NGG page)
3- optimizing in nextgen gallery view will keep loading till manual refresh the page
4- image not optmized in media but optimized on next gen gallery
download (34)

5- open bulk page at next -gen gallery will result in
[19-Mar-2024 09:03:17 UTC] PHP Deprecated: Function _imagify_display_bulk_page() is deprecated since version 1.7! Use Imagify_Views::get_instance()->display_bulk_page() instead. in /home/mai/Local Sites/imagifynginx6/app/public/wp-includes/functions.php on line 6078 => added GH #862

6- Generated next-gen is yes for this image although webp no generated for main image
marchmed1

7- Restore original isnot clickable while generate webp link is there
Screenshot from 2024-03-19 15-31-10

8- The new size > original size and both != that in media library (if generate webP is off , new size < original but still != that in media library)
Screenshot from 2024-03-20 11-40-49
Screenshot from 2024-03-20 11-43-53

9- Progress bar in bulk optimization of next gen gallery is 0 while the chartbar is != 0
Screenshot from 2024-03-20 11-49-41

10- imagify all keeps loading after being clicked in next-gen bulk optimization although % is 100 till manually refresh the page

on 2.2.0.1 already
#863

on 2.2.1

  • enable avif after uploading n images at next-gen will result in generating -n/0 (keeps loading ) in settings page of imagify. @piotrbak do we need to fix this on PR or it needs other GH? (similar issue was already fixed in media library when disable avif, however, it's happening in next-gen gallery when enable/disable avif) => agreed to be different issue

@remyperona remyperona removed this from the 2.2.1 milestone Mar 19, 2024
@Mai-Saad Mai-Saad self-requested a review March 20, 2024 14:26
@Mai-Saad
Copy link

Test report
testrail-report-587.pdf
failed test due to the point mentioned on 2.2.1 above ..

@piotrbak
Copy link

@Mai-Saad As we talked, we'll be good here. 1st and 5th point will deserve the separate GH, the same for the one you meantioned as the last point on 2.2.1

@Mai-Saad Mai-Saad added this pull request to the merge queue Mar 21, 2024
Merged via the queue into develop with commit 0100d20 Mar 21, 2024
5 checks passed
@Mai-Saad Mai-Saad deleted the fix/next-gen-gallery branch March 21, 2024 09:43
@piotrbak piotrbak added this to the 2.2.1 milestone Mar 21, 2024
@remyperona remyperona mentioned this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants