Fixes #833 Delete all next-gen versions on restore original image

[remyperona]

Description

Correctly delete all next-gen versions on restore original image by passing the second parameter of the methods to true

Fixes #833

Type of change

• Bug fix (non-breaking change which fixes an issue).

Checklists

Feature validation

• I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
• I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

• I wrote self-explanatory code about what it does.
• I did not introduce unecessary complexity.

[Mai-Saad]

related test plan https://wpmediaqa.testrail.io/index.php?/runs/view/825&group_by=cases:section_id&group_order=asc

[jeawhanlee]

Testing in progress...

[jeawhanlee]

Thank you for the PR @Tabrisrp.
During execution of test plan, with webp versions available and avif enabled, when reoptimize with lossless compression is clicked the webp versions are deleted and avif created, While on trunk webp versions is untouched, Do we need to fix this @piotrbak ?

[piotrbak]

Yes, that sounds like a regression. @Tabrisrp the lossless/smart compression is related to the image optimization only, not the generation of webp/avif, right?

[remyperona]

The lossless level also applies to the next-gen versions, so it makes sense to delete and re-create them too

[piotrbak]

@Tabrisrp Looks like @Mai-Saad and @jeawhanlee were correct here. Currently in 2.2 we're not touching the version that's not enabled.

Is this a big effort to redo this change?

[remyperona]

It would mean to go back to the previous state, so the issue this PR is fixing would not be fixed.

Re-optimizing process is first restore the original, then optimize again with new settings, so it uses the same underlying restore methods.

[MathieuLamiot]

@piotrbak how can we align on the expected behavior to move forward? Should we set up a quick call this afternoon or not needed?

[piotrbak]

@MathieuLamiot I think we're okay with what @Tabrisrp explained.

@Mai-Saad We'll need to update the TCs

[Mai-Saad]

testrail-report-585.pdf