-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #794 display the smaller size on image library data #810
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should go further on this one, updating this method and other methods in the class that reference webp, to make it work with the new implementation (using next-gen). This would also require to update the interface.
If I understand correctly, we should update the method from webp to nextgen ? |
Yes, update all occurrences of webp to nextgen. I see there is also a use of |
…ersions button (#805)
@Khadreal Thanks for the PR. working as in trunk after merging main branch to the PR locally while image have only webp. Note: we have some discussion about sizes here (probably it isnot always the smallest on trunk), however, the agreed expected shall be in separate GH as it's the case on trunk. Update: as per slack discussion, we shall display here the size of avif , if not exist then webp, if not exist then optimized => now we display in media library new size as per enabled option. which doesn't meet this update from slack. @Khadreal can you please check? /cc @piotrbak |
This PR #851 once merge will fixed the failing test error |
@Khadreal should this go back to ready for review, or there are still work needed here? |
I'll move it, done with the work but didn't move it because of the test failing |
@Khadreal Thanks for the update. Please find exploratory note below:
or can you please check? Note: in general, related test case https://wpmediaqa.testrail.io/index.php?/cases/view/15271 |
@Khadreal Thanks for the update, fixed in both scenarios mentioned above but can see problem if we refresh admin after scenario 2 i.e in log can see note: it happens with any optimized image not just the previous one |
Fixed. please check again. |
@Khadreal Thanks for the update. Working fine now with the following note (which is fine as per https://wp-media.slack.com/archives/CU0F6EGQ1/p1709546156479809?thread_ts=1709458320.636499&cid=CU0F6EGQ1)
|
Description
Display the smaller size of the image(avif)
Fixes #794
Documentation
User documentation
This will show the avif image size & percentage when available
Technical documentation
Explain how this code works. Diagram & drawings are welcomed.
Type of change
New dependencies
N/A
Risks
List possible performance & security issues or risks, and explain how they have been mitigated.
Checklists
Feature validation
Code style