-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #728 Replace out of quota notice by upsell block #752
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job Boss, very minor change requests or questions to discuss.
@Tabrisrp The icon This is because it is of the same color as the background. Using the Can you please look into this? |
@Tabrisrp I got the following PHP fatal error: PHP Fatal error: Uncaught TypeError: call_user_func_array(): Argument #1 ($callback) must be a valid callback, class Imagify\Notices\Notices does not have a method "renew_almost_over_quota_notice" in /var/www/vasilis.rocketlabsqa.ovh/htdocs/wp-includes/class-wp-hook.php:312
Stack trace:
#0 /var/www/vasilis.rocketlabsqa.ovh/htdocs/wp-includes/class-wp-hook.php(334): WP_Hook->apply_filters()
#1 /var/www/vasilis.rocketlabsqa.ovh/htdocs/wp-includes/plugin.php(517): WP_Hook->do_action()
#2 /var/www/vasilis.rocketlabsqa.ovh/htdocs/wp-content/plugins/imagify/classes/User/User.php(221): do_action()
#3 /var/www/vasilis.rocketlabsqa.ovh/htdocs/wp-content/plugins/imagify/classes/User/User.php(241): Imagify\User\User->get_percent_consumed_quota()
#4 /var/www/vasilis.rocketlabsqa.ovh/htdocs/wp-content/plugins/imagify/views/part-upsell.php(8): Imagify\User\User->get_percent_unconsumed_quota()
#5 /var/www/vasilis.rocketlabsqa.ovh/htdocs/wp-content/plugins/imagify/inc/classes/class-imagify-views.php(590): include('...')
#6 /var/www/vasilis.rocketlabsqa.ovh/htdocs/wp-content/plugins/imagify/inc/classes/class-imagify-views.php(605): Imagify_Views->get_template()
#7 /var/www/vasilis.rocketlabsqa.ovh/htdocs/wp-content/plugins/imagify/views/part-settings-account.php(33): Imagify_Views->print_template()
#8 /var/www/vasilis.rocketlabsqa.ovh/htdocs/wp-content/plugins/imagify/inc/classes/class-imagify-views.php(590): include('...')
#9 /var/www/vasilis.rocketlabsqa.ovh/htdocs/wp-content/plugins/imagify/inc/classes/class-imagify-views.php(605): Imagify_Views->get_template()
#10 /var/www/vasilis.rocketlabsqa.ovh/htdocs/wp-content/plugins/imagify/views/page-settings.php(87): Imagify_Views->print_template()
#11 /var/www/vasilis.rocketlabsqa.ovh/htdocs/wp-content/plugins/imagify/inc/classes/class-imagify-views.php(590): include('...')
#12 /var/www/vasilis.rocketlabsqa.ovh/htdocs/wp-content/plugins/imagify/inc/classes/class-imagify-views.php(605): Imagify_Views->get_template()
#13 /var/www/vasilis.rocketlabsqa.ovh/htdocs/wp-content/plugins/imagify/inc/classes/class-imagify-views.php(242): Imagify_Views->print_template()
#14 /var/www/vasilis.rocketlabsqa.ovh/htdocs/wp-includes/class-wp-hook.php(310): Imagify_Views->display_settings_page()
#15 /var/www/vasilis.rocketlabsqa.ovh/htdocs/wp-includes/class-wp-hook.php(334): WP_Hook->apply_filters()
#16 /var/www/vasilis.rocketlabsqa.ovh/htdocs/wp-includes/plugin.php(517): WP_Hook->do_action()
#17 /var/www/vasilis.rocketlabsqa.ovh/htdocs/wp-admin/admin.php(259): do_action()
#18 /var/www/vasilis.rocketlabsqa.ovh/htdocs/wp-admin/options-general.php(10): require_once('...')
#19 {main}
thrown in /var/www/vasilis.rocketlabsqa.ovh/htdocs/wp-includes/class-wp-hook.php on line 312 It seems that the If that's the way it should be, the following should be removed as well: imagify-plugin/classes/Notices/Notices.php Line 137 in 1ad55b5
|
@Tabrisrp There is another fatal error coming from here: imagify-plugin/views/part-upsell.php Line 65 in 1ad55b5
Can you please look into this as well? 🙏 |
@Tabrisrp Thank you for the fixes. I don't see the implementation of the Black Friday promotion where text and URLs for upgrades should differ from the ones usually used. Should this be part of the specific PR? |
@vmanthos In the acceptance criteria, Piotr specified that the promo changes are not to be included in this PR |
Thank you for checking, @Tabrisrp! That was in bold, but still I managed to miss it. 😅 |
@Tabrisrp @wp-media/productimagify The notice is correctly displayed and it's dismissable. According to the specs doc:
Currently, the banner is displayed when the unconsumed quota is less than 20% of the plan's quota. If the banner is dismissed and more quota is used the banner isn't displayed. Should it be when the unconsumed quota is 0%, or anything different? 🙏 |
The dismiss is reset if the quota gets back above 20%, and the banner should show again after that when it gets below 20%. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as expected! 👍
TestRail report: testrail-report-542.pdf
NOTE
Black Friday promotion deals haven't been implemented in the current PR.
Description
Display an upsell banner and offer users who are out of the quota to upgrade to a higher plan.
Remove the banner at the top, we don’t need both banners since the same information would be displayed.
Fixes #728
Type of change
Is the solution different from the one proposed during the grooming?
No
Checklists
Generic development checklist
Test summary