Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: application store architecture #135

Merged
merged 47 commits into from
May 17, 2024
Merged

refactor: application store architecture #135

merged 47 commits into from
May 17, 2024

Conversation

josephfusco
Copy link
Member

@josephfusco josephfusco commented Apr 29, 2024 •
edited
Loading

These changes include:

  • new API for registering buttons within the Document Editor
  • refactor plugin architecture to be "contributor first"
  • implement caching strategies in relevant GitHub workflows
  • pre-existing button e2e tests in main are passing

@josephfusco josephfusco changed the title Refactor application store architecture refactor: application store architecture Apr 29, 2024
josephfusco and others added 22 commits April 30, 2024 12:10
@josephfusco
Use name as key
23e1b0e
@josephfusco
Handle attempted registration of duplicate names
8c50257
@josephfusco
Merge branch 'main' into poc-3rd-party-plugin
6c1feee
@josephfusco
save
04dfda4
@josephfusco
save
a2a30bc
@josephfusco
Pull in third-party-plugin from separate repo
37528f1
@josephfusco
save
ff69c3b
@josephfusco
save
2ac7be8
@josephfusco
save
7a93015
@josephfusco
save
00fb344
@jasonbahl
- update third-party-plugin.php to not fatal if dependencies have not…
7aba26f 
… been built yet
@jasonbahl
- update .gitignore
ba43a12 
- remove .zip from versioning
@jasonbahl
- update app-store.js to support prettify action
79dbb90
@jasonbahl
- remove store/app-store.js in favor of store/app-store/index.js
8bba62c 
- moved reducers, actions, selectors into their own files
- update .css to be valid
- update DynamicToolbarButton
@josephfusco
Port merge fragments button to new API
c8e262f
@josephfusco
Add merge fragments button
710d73d
@josephfusco
save but broken
d697ef3
@jasonbahl
- import selectors from selectors, not from actions
2061c98
@jasonbahl
- update path to EditorToolbar component
ed45477
@jasonbahl
- move buttons from third-party-plugin into core plugin under registry
0eae15a
@josephfusco
save
3fc123b
@josephfusco
save
f061bb3
@jasonbahl jasonbahl mentioned this pull request May 15, 2024
Closed
@josephfusco josephfusco mentioned this pull request May 17, 2024
Merged
5 tasks
@josephfusco josephfusco changed the base branch from main to beta May 17, 2024 18:09
@josephfusco josephfusco marked this pull request as ready for review May 17, 2024 18:09
@josephfusco josephfusco merged commit 7c9660f into beta May 17, 2024
2 checks passed
@josephfusco josephfusco deleted the poc-3rd-party-plugin branch May 17, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jasonbahl jasonbahl

@josephfusco josephfusco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephfusco @jasonbahl