Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Defer script to reduce the initial delay w/ opening of drawer #134

Merged
merged 10 commits into from
May 7, 2024
Merged

fix: Defer script to reduce the initial delay w/ opening of drawer #134

merged 10 commits into from
May 7, 2024

Conversation

josephfusco
Copy link
Member

@josephfusco josephfusco commented Apr 25, 2024 •
edited
Loading

Proposed solution for issue #124:

  • Removed the check for DOMContentLoaded in order to help client side performance with heavier pages.
  • Added new PHP filters for updating the drawer label:
    • wpgraphqlide_drawer_button_label
    • wpgraphqlide_drawer_button_loading_label
  • Added defer attribute to enqueued plugin script.
defer.script.fix.mov

proposed fix with defer attribute

@josephfusco josephfusco changed the title Defer script to assist with lowering the drawer delay on some pages fix: Defer script to assist with lowering the drawer delay on some pages Apr 25, 2024
@josephfusco josephfusco changed the title fix: Defer script to assist with lowering the drawer delay on some pages fix: Defer script to reduce the initial delay of the the react app mounting Apr 26, 2024
@josephfusco josephfusco changed the title fix: Defer script to reduce the initial delay of the the react app mounting fix: Defer script to reduce the initial delay w/ opening of drawer Apr 26, 2024
@josephfusco josephfusco self-assigned this Apr 29, 2024
@josephfusco josephfusco marked this pull request as ready for review May 6, 2024 21:08
@josephfusco josephfusco requested a review from jasonbahl May 6, 2024 21:10
josephfusco
josephfusco commented May 6, 2024
View reviewed changes
wpgraphql-ide.php
Comment on lines +314 to +315
'drawerButtonLabel' => apply_filters( 'wpgraphqlide_drawer_button_label', '🚀' ),
'drawerButtonLoadingLabel' => apply_filters( 'wpgraphqlide_drawer_button_loading_label', '⏳' ),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏻

@josephfusco josephfusco merged commit 4433643 into main May 7, 2024
8 checks passed
@josephfusco josephfusco mentioned this pull request May 7, 2024
Closed
1 task
@jasonbahl jasonbahl deleted the fix/issue-124-drawer-delay branch May 17, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonbahl jasonbahl Awaiting requested review from jasonbahl

Assignees

@josephfusco josephfusco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@josephfusco