Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When published query is edited, offer save as draft #255

Closed

Conversation

markkelnar
Copy link
Contributor

@markkelnar markkelnar commented Aug 22, 2023

For a saved query string that is in published state, when saving, reject the save if the query string has changed. Show an error message at the top.

Also add a 'save as draft' option for save.

closes #254

Screenshot 2023-08-22 at 4 08 45 PM

@markkelnar markkelnar changed the title When published query is edited, offer save as new When published query is edited, offer save as draft Aug 24, 2023
@markkelnar markkelnar requested a review from jasonbahl August 24, 2023 17:16
@markkelnar
Copy link
Contributor Author

markkelnar commented Aug 24, 2023

I changed it to "Save as draft", because "Save as new" confused me. It wasn't obvious that it was saved as a new post or that it was in draft state, until I looked at the lists page. Maybe the text of that checkbox should be "Copy as draft". "Save as new draft"?

@jasonbahl jasonbahl added needs: author response Pending information from the author needs: reviewer response This needs the attention of a codeowner or maintainer and removed needs: author response Pending information from the author labels Sep 19, 2023
@jasonbahl
Copy link
Collaborator

Closing and will follow up later when working on #259.

We can reference this PR at that time if needed.

@jasonbahl jasonbahl closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: reviewer response This needs the attention of a codeowner or maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not allow query strings to be edited in Editor for published queries
2 participants