Phpstan level 7 changes #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonbahl
reviewed
Aug 2, 2023
| @@ -570,8 +582,7 @@ public function on_transition_post_status_cb( $new_status, $old_status, WP_Post | |||
| $action_type = 'CREATE'; | |||
| } | |||
|
|
|||
| $post_type_object = get_post_type_object( $post->post_type ); | |||
| $type_name = $post_type_object instanceof \WP_Post_Type ? strtolower( $post_type_object->graphql_single_name ) : $post_type_object; | |||
| $type_name = strtolower( $post_type_object->graphql_single_name ); | |||
There was a problem hiding this comment.
So with changes like this we really need to be careful that we're only executing code when WPGraphQL is active.
If WPGraphQL Smart Cache were active but WPGraphQL was not active, and the invalidation callbacks were fired, I think this would be some fatals.
So, we should check to ensure we're only executing code if WPGraphQL is already active. 👀
There was a problem hiding this comment.
Ok, I confirmed this is the case: https://github.com/wp-graphql/wp-graphql-smart-cache/blob/main/wp-graphql-smart-cache.php#L191-L210
jasonbahl
approved these changes
Aug 2, 2023
|
@markkelnar I had one concern while reviewing, but I went and confirmed that we're already protecting against said scenario. Approved. LGTM 💃🏻 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for phpstan levels 6 and 7.
Issue reference