Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow query strings to be edited in Editor for published queries #254

Closed
markkelnar opened this issue Aug 22, 2023 · 1 comment
Closed

Do not allow query strings to be edited in Editor for published queries #254

markkelnar opened this issue Aug 22, 2023 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@markkelnar
Copy link
Contributor

When a saved persisted query has been published, changing the query string changes the autmoatically calculated alias hash string. This removes the existing/old alias hash making it unusable and potentially breaking any client apps using that query.

This change will prevent the WP admin editor from allowing edits to an already published saved query string.
@markkelnar markkelnar mentioned this issue Aug 22, 2023
Closed
@ChrisWiegman ChrisWiegman mentioned this issue Sep 12, 2023
Open
@jasonbahl jasonbahl added the duplicate This issue or pull request already exists label Sep 15, 2023
@josephfusco
Copy link
Member

Closing in favor of #259 as this was marked duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

When published query is edited, offer save as draft markkelnar/wp-graphql-smart-cache
3 participants
@markkelnar @jasonbahl @josephfusco