Merge pull request #239 from markkelnar/phpstan-level-1-fixes

fixes for phpstan level increase strictness

phpstan.neon.dist

@@ -1,12 +1,13 @@
 parameters:
-    level: 0
+    level: 2
     inferPrivatePropertyTypeFromConstructor: true
     checkMissingIterableValueType: false
     stubFiles:
         # Simulate added properties
         - phpstan/class-wp-post-type.stub
         - phpstan/class-wp-taxonomy.stub
         - phpstan/class-wp-dependency.stub
+        - phpstan/appsero.stub
     bootstrapFiles:
         - phpstan/constants.php
         - vendor/wp-graphql/wp-graphql/wp-graphql.php

phpstan/appsero.stub

@@ -0,0 +1,30 @@
+<?php
+/**
+ * This stub file fixes return type from appsero client class function.
+ **/
+
+namespace Appsero;
+
+/**
+ * Appsero Insights
+ *
+ * This is a tracker class to track plugin usage based on if the customer has opted in.
+ * No personal information is being tracked by this class, only general settings, active plugins, environment details
+ * and admin email.
+ */
+class Insights {}
+
+/**
+ * Appsero Client
+ *
+ * This class is necessary to set project data
+ */
+class Client {
+
+    /**
+     * Initialize insights class
+     *
+     * @return \Appsero\Insights
+     */
+    public function insights();
+}

src/Admin/Editor.php

@@ -193,7 +193,7 @@ public static function maxage_input_box_cb( $post ) {
 	/**
 	 * Change the text from Excerpt to Description where it is visible.
 	 *
-	 * @param String  The string for the __() or _e() translation
+	 * @param String $string The string for the __() or _e() translation
 	 * @return String  The translated or original string
 	 */
 	public function translate_excerpt_text_cb( $string ) {

src/Cache/Query.php

@@ -68,7 +68,7 @@ public function build_key( $query_id, $query, $variables = null, $operation = nu
 	/**
 	 * Get the data from cache/transient based on the provided key
 	 *
-	 * @param string unique id for this request
+	 * @param string $key unique id for this request
 	 * @return mixed|array|object|null  The graphql response or null if not found
 	 */
 	public function get( $key ) {
@@ -78,9 +78,9 @@ public function get( $key ) {
 	/**
 	 * Converts GraphQL query result to spec-compliant serializable array using provided function
 	 *
-	 * @param string unique id for this request
-	 * @param mixed|array|object|null  The graphql response
-	 * @param int Time in seconds for the data to persist in cache. Zero means no expiration.
+	 * @param string $key unique id for this request
+	 * @param mixed|array|object|null $data The graphql response
+	 * @param int $expire Time in seconds for the data to persist in cache. Zero means no expiration.
 	 *
 	 * @return bool False if value was not set and true if value was set.
 	 */
@@ -91,7 +91,7 @@ public function save( $key, $data, $expire = DAY_IN_SECONDS ) {
 	/**
 	 * Delete the data from cache/transient based on the provided key
 	 *
-	 * @param string unique id for this request
+	 * @param string $key unique id for this request
 	 * @return bool True on successful removal, false on failure.
 	 */
 	public function delete( $key ) {