Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AcfFieldTypeSettingsBlock breaks when there are no field type settings configured #41

Merged
merged 1 commit into from
Dec 20, 2023
Merged

fix: AcfFieldTypeSettingsBlock breaks when there are no field type settings configured #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion wp-blocks/AcfFieldTypeSettingsBlock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,17 @@ export function AcfFieldTypeSettingsBlock({ fieldTypeSettingsBlockFields }) {
}
};


if ( ! fieldTypeSettings?.nodes?.length ) {
return (
<Card>
<CardHeader className="grid grid-cols-[1fr_110px] items-start space-y-2">
Field Type Settings not yet configured for this field type
</CardHeader>
</Card>
);
}

return (
<>
<Card>
Expand Down Expand Up @@ -77,7 +88,7 @@ export function AcfFieldTypeSettingsBlock({ fieldTypeSettingsBlockFields }) {
<CardFooter>
<div className="flex justify-center items-center space-x-4 w-full">
<Button variant="ghost" onClick={toggleAll} className="w-full">
{openItems.length === fieldTypeSettings.nodes.length ? 'Collapse All' : 'Expand All'}
{openItems.length === fieldTypeSettings?.nodes?.length ? 'Collapse All' : 'Expand All'}
</Button>
</div>
</CardFooter>
Expand Down