Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wpcs in cpt generation #110

Merged
merged 4 commits into from
Jan 8, 2018
Merged

fix wpcs in cpt generation #110

merged 4 commits into from
Jan 8, 2018

Conversation

thrijith
Copy link
Member

@thrijith thrijith commented Jan 7, 2018

update code to remove WPCS warnings in CPT generation #109

@gitlost gitlost added this to the 1.1.2 milestone Jan 8, 2018
Copy link
Contributor

@gitlost gitlost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thrijith , suggested some changes.

templates/post_type_extended.mustache Outdated Show resolved Hide resolved
templates/post_type_extended.mustache Outdated Show resolved Hide resolved
templates/post_type_extended.mustache Outdated Show resolved Hide resolved
templates/post_type_extended.mustache Outdated Show resolved Hide resolved
templates/post_type_extended.mustache Outdated Show resolved Hide resolved
templates/post_type_extended.mustache Outdated Show resolved Hide resolved
templates/post_type_extended.mustache Outdated Show resolved Hide resolved
templates/post_type_extended.mustache Outdated Show resolved Hide resolved
templates/post_type_extended.mustache Outdated Show resolved Hide resolved
@thrijith
Copy link
Member Author

thrijith commented Jan 8, 2018

@gitlost made mentioned changes along with some other WPCS warnings I found regarding array => alignment.

templates/post_type_extended.mustache Outdated Show resolved Hide resolved
gitlost
gitlost previously approved these changes Jan 8, 2018
@gitlost gitlost dismissed their stale review January 8, 2018 20:02

Forgot to check the tests!

@gitlost gitlost merged commit f4a7eac into wp-cli:master Jan 8, 2018
@gitlost
Copy link
Contributor

gitlost commented Jan 8, 2018

Done! Thanks @thrijith !

@gitlost gitlost mentioned this pull request Jan 8, 2018
danielbachhuber pushed a commit that referenced this pull request Nov 18, 2022
fix wpcs in cpt generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants