Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Silence Requests deprecation #272

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Tests: Silence Requests deprecation #272

wants to merge 2 commits into from

Conversation

swissspidy
Copy link
Member

At the moment we don't hide PHP warnings and deprecations in Behat tests anymore, which helps surface potential issues with the tess.

There is currently 1 test failing because of that.

Example test run: https://github.com/wp-cli/core-command/actions/runs/11136463362/job/30948399200#step:11:36

001 Scenario: Make sure files are cleaned up with mixed case # features/core-update.feature:264
      Then STDOUT should be a number                         # features/core-update.feature:341
        Actual value: 'Deprecated: The PSR-0 `Requests_...` class names in the Request library are deprecated. Switch to the PSR-4 `WpOrg\\Requests\\...` class names at your earliest convenience. in /tmp/wp-cli-test-run--66fcaeaf29b076.48217376/wp-includes/class-requests.php on line 24
        4' (Exception)

This fix should address this warning.

@swissspidy swissspidy added this to the 2.1.19 milestone Oct 2, 2024
@swissspidy swissspidy requested a review from a team as a code owner October 2, 2024 10:55
@swissspidy
Copy link
Member Author

Okay that didn't work 🤔

@swissspidy swissspidy marked this pull request as draft October 2, 2024 11:09
@swissspidy
Copy link
Member Author

Not sure how I could silence the deprecations if not using an mu-plugin...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant