Making reusable-regenerate-readme GitHub-y

[szepeviktor]

Use GHA outputs and true/false as values 🎉

-        if: env.CHANGES_DETECTED == 1
+        if: ${{ steps.check_changes.outputs.detected == 'true' }}

Please see comments below.

Some viktor utopia for consideration

• quote every YAML string
• indent with 4 space 👁️👁️

May I continue with other actions ❔

[szepeviktor]

This may get emotional.
👨🏻‍🎨

[szepeviktor]

Put things in chronological order.
env is prerequisite.

[szepeviktor]

Protect shell scripts. Use long options.

[schlessera]

@szepeviktor Yes, happy to accept even more changes to get this to an idiomatic way of writing GHA workflows.

[danielbachhuber]

Some viktor utopia for consideration

I think this might be a bit much 😁

The other changes seem fine. I'll defer to @schlessera for merge.

[szepeviktor]

Now unit and feature test detection are separate jobs.

.github/.github/workflows/reusable-testing.yml

Lines 14 to 28 in 0086fd4

	has_unit_tests:
	runs-on: ubuntu-20.04
	steps:
	- name: Check out source code
	uses: actions/checkout@v3
	- name: Check existence of composer.json file
	id: check_files
	uses: andstor/file-existence-action@v2
	with:
	files: "composer.json, phpunit.xml.dist"
	outputs:
	exists: ${{ steps.check_files.outputs.files_exists }}

Could you test it? Then I will finish GitHubify the rest.

[danielbachhuber]

@szepeviktor Thanks! I'll defer to @schlessera when he's available. My opinions about GitHub workflows are less strong/informed.

[szepeviktor]

My opinions about GitHub workflows are less strong/informed.

I also use a cat+keyboard combo to send pull requests 🐈⌨️