Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize codebase #16

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Modernize codebase #16

merged 3 commits into from
Jan 23, 2024

Conversation

gdebrauwer
Copy link
Collaborator

  • remove code that was specific for old laravel versions
  • use collections instead of arrays in translationmanager
  • switch to laravel's HTTP client instead of a guzzle client
  • update poeditor class to ensure it can handle a rate limiting error when uploading translations

Base automatically changed from remove-docblocks-and-use-returntypes to master January 23, 2024 06:38
@gdebrauwer gdebrauwer merged commit f654608 into master Jan 23, 2024
14 checks passed
@gdebrauwer gdebrauwer deleted the modernize-codebase branch January 23, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bart-Kuenen-nextapps Bart-Kuenen-nextapps Bart-Kuenen-nextapps approved these changes

@yinx yinx yinx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gdebrauwer @yinx @Bart-Kuenen-nextapps