Allow using a UUID-based URN as the ID in the device's TD #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu-zero
reviewed
Nov 24, 2024
|
It looks good and adding a feature to switch back and forth might be a nice way to evaluate w3c/wot-thing-description#2054 |
JKRhb
changed the title
|
Okay, this PR should now be ready for a final review :) |
lu-zero
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the device does not use a UUID as the
idin its Thing Description but the device ID. As a potential improvement, this PR lets the application generate a UUID-based URN instead via thenuuidcrate, which is probably a slightly better practice (although the device ID is probably also unique already). As this causes slightly more overhead, I am wondering whether this change should be hidden via a feature flag, with the old approach as a fallback.