Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #8

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Update README.md #8

merged 3 commits into from
Nov 21, 2023

Conversation

idigdoug
Copy link
Collaborator

No description provided.

@idigdoug idigdoug marked this pull request as ready for review November 20, 2023 22:45
@mariobalanica
Copy link
Member

"USB 3 Host port 2" description looks okay, but "USB 3 Host ports 0 and 1" are actually dual-role: Type-C and on most RK3588 boards also a Type-A port. OPi 5+ has a hub connected to one of them, so it's the only supported board so far with two fully working USB 3 ports.

Since dual-role functionality doesn't work and I've seen issues with a few devices (especially connected to Type-C), it would be better for it to remain "Partially working" with the original description + the clarifications above.

PCIe doesn't work with all devices that have drivers: some expect a cache coherent bus, others require MSI (Qualcomm Wi-Fi cards), XHCI wants a root port. We could add a list below with the known working devices.

@idigdoug
Copy link
Collaborator Author

"USB 3 Host port 2" description looks okay, but "USB 3 Host ports 0 and 1" are actually dual-role: Type-C and on most RK3588 boards also a Type-A port. OPi 5+ has a hub connected to one of them, so it's the only supported board so far with two fully working USB 3 ports.

Since dual-role functionality doesn't work and I've seen issues with a few devices (especially connected to Type-C), it would be better for it to remain "Partially working" with the original description + the clarifications above.

Text in main has "USB 3 Host" as "Working", and "USB 3 Dual Role" on a separate line "Partially working". This PR doesn't change that.

And this change has a note "while RK3588s devices have only 1 'full' USB3 port".

So I'm not sure what you're suggesting. Maybe move the "USB 3 Dual Role" line up above the "USB Host port 2"?

PCIe doesn't work with all devices that have drivers: some expect a cache coherent bus, others require MSI (Qualcomm Wi-Fi cards), XHCI wants a root port. We could add a list below with the known working devices.

Good point. I'll fix that.

@mariobalanica
Copy link
Member

Looks good now. Thanks!

@mariobalanica mariobalanica merged commit 6fd0aab into master Nov 21, 2023
2 checks passed
@idigdoug idigdoug deleted the readme branch November 21, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants